Skip to content

[SN-145] removed buffered stream mentioning #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

[SN-145] removed buffered stream mentioning #1662

merged 1 commit into from
Jun 7, 2024
+17 −17

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jun 7, 2024 •
edited
Loading

Description

get_stream is deprecated, so I switched export streamables to get_buffered_stream, which is not deprecated.

Type of change

  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Gabefire Gabefire changed the title [SN-145]removed buffered stream mentioning [SN-145] removed buffered stream mentioning Jun 7, 2024
@Gabefire Gabefire added the document Document changes label Jun 7, 2024
@Gabefire Gabefire requested a review from mina-ebeid June 7, 2024 20:28
@mina-ebeid mina-ebeid self-assigned this Jun 7, 2024
mina-ebeid
mina-ebeid approved these changes Jun 7, 2024
View reviewed changes
Copy link

@mina-ebeid mina-ebeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gabefire Gabefire merged commit d77170f into develop Jun 7, 2024
20 of 25 checks passed
@Gabefire Gabefire deleted the gu/switched_buffered_stream branch June 7, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mina-ebeid mina-ebeid mina-ebeid approved these changes

Assignees

@mina-ebeid mina-ebeid

Labels
document Document changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabefire @mina-ebeid